Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Push Github Action #83
Docker Push Github Action #83
Changes from all commits
4017d17
2b29eeb
5e01f28
2900646
79ba1df
b00a7d9
25373a9
403e70c
29d2850
4c35ea4
2fa3a1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest defaulting this arg to
linux/amd64
so it just works for a regulardocker build
invocation:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will never work for a
docker build .
invocation now :)since the Dockerfile is only a means for packaging the binary and the binary is built on the host , relates to http://github.com/envoyproxy/gateway/issues/93
Instead we need to rely on
make docker-build
nowAs for
TARGETPLATFORM=linux/amd64
, we dont need this, by default it picks the right valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I run
make docker-build
as is, thendocker run
the image, I getexec /usr/local/bin/envoy-gateway: no such file or directory
. If I add the default I suggested, then do the same, I getManages Envoy Proxy as a standalone or Kubernetes-based application gateway
as expected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is environment dependent, if you did
docker buildx install
then yourdocker build
is buildx otherwise it's not. Though defaults to linux/amd64 doesn't do right thing for M1 mac users whose docker is linux/arm64.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, set environment DOCKER_BUILDKIT=1 in the Makefile should make thing work? @skriss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, understood, was just trying to have this work OOTB for the most environments. Since you're against the default, let's document the
buildx
requirement in https://github.com/envoyproxy/gateway/blob/main/CONTRIBUTING.md.