Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8273 +/- ##
==========================================
+ Coverage 73.64% 73.68% +0.03%
==========================================
Files 242 243 +1
Lines 37007 37108 +101
==========================================
+ Hits 27255 27343 +88
- Misses 7831 7838 +7
- Partials 1921 1927 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // DecompressorType defines the decompressor type to use for decompression. | ||
| // | ||
| // +required | ||
| Type DecompressorType `json:"type"` |
There was a problem hiding this comment.
Let's add CEL validations for discriminated union type here
gateway/api/v1alpha1/healthcheck_types.go
Lines 127 to 128 in fa3ff1d
| @@ -141,6 +141,8 @@ func newOrderedHTTPFilter(filter *hcmv3.HttpFilter) *OrderedHTTPFilter { | |||
| order = 305 | |||
| case isFilterType(filter, egv1a1.EnvoyFilterCredentialInjector): | |||
| order = 307 | |||
| case isFilterType(filter, egv1a1.EnvoyFilterDecompressor): | |||
There was a problem hiding this comment.
We need to reconsider ordering, especially for response_direction_config
By default, decompressor runs on the response path. Wouldn't the response go through this path now?
upstream -> envoy cluster -> compressor -> decompressor -> envoy listener -> client
If so, the decompressor would decompress the payload that the compressor compressed.
Worth having an integration test with both filters enabled to verify
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
aburan28
force-pushed
the
adam--decompress
branch
from
2e5824e to
a8a2340
Compare
3 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No