Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds API to Manage Envoy Deployment #766

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Dec 1, 2022

  • Moves ProviderType to api/config/v1alpha1/shared_types.go since the types are being used by EnvoyGateway and EnvoyProxy APIs.
  • Adds ResourceProvider type to EnvoyProxy API to define the desired state of supported infrastructure resources.
  • Generates DeepCopy methods and CRD manifest.

xref #713

Signed-off-by: danehans daneyonhansen@gmail.com

@danehans danehans requested a review from a team as a code owner December 1, 2022 18:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #766 (7914962) into main (7e176de) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   62.01%   62.03%   +0.01%     
==========================================
  Files          46       46              
  Lines        5995     5995              
==========================================
+ Hits         3718     3719       +1     
+ Misses       2043     2042       -1     
  Partials      234      234              
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 73.38% <0.00%> (-0.81%) ⬇️
internal/provider/kubernetes/controller.go 52.22% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans danehans changed the title Adds ResourceProvider Type to EnvoyProxy API Adds API to Manage Envoy Deployment Dec 1, 2022
@arkodg
Copy link
Contributor

arkodg commented Dec 5, 2022

@danehans this PR looks good, but prefer if we design and the deliver platform customizations in a future release (v0.4.0) so we scope out the exact type of platform customizations the project will support. For e.g. will the project also support HPA based replica fields ?

@danehans
Copy link
Contributor Author

danehans commented Dec 5, 2022

@arkodg thanks for the review and feedback. Since we have multiple requests for providing basic Envoy infra configurability, I disagree that we should wait to provide this feature:

xrefs:
#713
#648
#703

For e.g. will the project also support HPA based replica fields ?

I see HPA as "advanced configuration" that can be supported in the future.

@Xunzhuo @youngnick @skriss @AliceProxy WDYT?

@Alice-Lilith
Copy link
Member

I definitely think that the Envoy infra should be customizable for the end user.

@arkodg
Copy link
Contributor

arkodg commented Dec 6, 2022

I definitely think that the Envoy infra should be customizable for the end user.

agree @AliceProxy , im suggesting delaying this until its part of a roadmap theme

@danehans
Copy link
Contributor Author

danehans commented Dec 6, 2022

im suggesting delaying this until its part of a roadmap theme

IMHO we would prioritize features that are being requested by users. As I mention in #766 (comment), we have multiple requests to provide basic Envoy infra configurability.

@danehans
Copy link
Contributor Author

danehans commented Dec 7, 2022

Per our discussion during the 12/6/22 community meeting, @youngnick @AliceProxy @arkodg agreed to proceed with the general approach of this PR. The approach of this PR is consistent with the EnvoyGateway API and solves Envoy infra configurability that's being requested by the community. Since the API is alpha, we can take a broader approach to infra configurability, e.g. exposing spec, if we find this approach unmaintainable. @arkodg @AliceProxy @youngnick PTAL at this PR when you have a moment.

arkodg
arkodg previously approved these changes Dec 7, 2022
Xunzhuo
Xunzhuo previously approved these changes Dec 8, 2022
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Xunzhuo
Copy link
Member

Xunzhuo commented Dec 8, 2022

/hold

Can we rebase with main before getting this merged?

Alice-Lilith
Alice-Lilith previously approved these changes Dec 8, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Copy link
Contributor Author

danehans commented Dec 9, 2022

@Xunzhuo @arkodg @AliceProxy per #766 (comment) I rebased. Please retag when you have a moment.

@arkodg arkodg merged commit b758d65 into envoyproxy:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants