-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds API to Manage Envoy Deployment #766
Conversation
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 62.01% 62.03% +0.01%
==========================================
Files 46 46
Lines 5995 5995
==========================================
+ Hits 3718 3719 +1
+ Misses 2043 2042 -1
Partials 234 234
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@danehans this PR looks good, but prefer if we design and the deliver platform customizations in a future release (v0.4.0) so we scope out the exact type of platform customizations the project will support. For e.g. will the project also support HPA based replica fields ? |
@arkodg thanks for the review and feedback. Since we have multiple requests for providing basic Envoy infra configurability, I disagree that we should wait to provide this feature:
I see HPA as "advanced configuration" that can be supported in the future. @Xunzhuo @youngnick @skriss @AliceProxy WDYT? |
I definitely think that the Envoy infra should be customizable for the end user. |
agree @AliceProxy , im suggesting delaying this until its part of a roadmap theme |
IMHO we would prioritize features that are being requested by users. As I mention in #766 (comment), we have multiple requests to provide basic Envoy infra configurability. |
Per our discussion during the 12/6/22 community meeting, @youngnick @AliceProxy @arkodg agreed to proceed with the general approach of this PR. The approach of this PR is consistent with the EnvoyGateway API and solves Envoy infra configurability that's being requested by the community. Since the API is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold Can we rebase with main before getting this merged? |
Signed-off-by: danehans <daneyonhansen@gmail.com>
7914962
54d17ec
to
7914962
Compare
@Xunzhuo @arkodg @AliceProxy per #766 (comment) I rebased. Please retag when you have a moment. |
ProviderType
toapi/config/v1alpha1/shared_types.go
since the types are being used by EnvoyGateway and EnvoyProxy APIs.ResourceProvider
type to EnvoyProxy API to define the desired state of supported infrastructure resources.xref #713
Signed-off-by: danehans daneyonhansen@gmail.com