Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start xds server watchable map panics #745

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 22, 2022

Fixes: #734
Fixes: #747
Fixes: #838

Signed-off-by: bitliu bitliu@tencent.com

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #745 (e550c4f) into main (6be6950) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   63.62%   63.10%   -0.52%     
==========================================
  Files          47       47              
  Lines        5927     5979      +52     
==========================================
+ Hits         3771     3773       +2     
- Misses       1921     1971      +50     
  Partials      235      235              
Impacted Files Coverage Δ
internal/infrastructure/kubernetes/service.go 48.33% <0.00%> (-27.00%) ⬇️
internal/provider/kubernetes/gateway.go 50.84% <0.00%> (-0.33%) ⬇️
internal/provider/kubernetes/httproute.go 58.53% <0.00%> (-0.73%) ⬇️
internal/provider/kubernetes/tlsroute.go 58.69% <0.00%> (-0.78%) ⬇️
internal/xds/server/runner/runner.go 23.65% <0.00%> (ø)
internal/provider/kubernetes/gatewayclass.go 75.36% <0.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo changed the title fix: update svc failed and trigger svc update wrongly fix: update svc failed & trigger svc update wrongly & watchable map panics Nov 22, 2022
@Xunzhuo Xunzhuo force-pushed the fix-restart branch 3 times, most recently from 2fd7044 to e3600c9 Compare November 22, 2022 11:00
@danehans
Copy link
Contributor

I'd like to get #702 merged before merging this PR.

@danehans
Copy link
Contributor

danehans commented Dec 5, 2022

@Xunzhuo now that #702 has merged, can you rebase this PR and remove the draft?

@Xunzhuo Xunzhuo added kind/bug Something isn't working area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. labels Dec 6, 2022
@Xunzhuo Xunzhuo mentioned this pull request Dec 29, 2022
@Xunzhuo Xunzhuo changed the title fix: update svc failed & trigger svc update wrongly & watchable map panics fix: start xds server watchable map panics Dec 29, 2022
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review December 29, 2022 15:17
@Xunzhuo Xunzhuo requested a review from a team as a code owner December 29, 2022 15:17
@Xunzhuo Xunzhuo enabled auto-merge (squash) December 29, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eg start failure xDS Runner Panics Occasionally restart gateway ,HandleSubscription panic
3 participants