Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Nov 6, 2025

Improve validateClusterStatName function, %ROUTE_NAME is invalid.

@zirain zirain requested a review from a team as a code owner November 6, 2025 04:26
@zirain zirain force-pushed the improv-validateClusterStatName branch 2 times, most recently from a4868ee to a382dd4 Compare November 6, 2025 05:28
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.31%. Comparing base (84cd21c) to head (6cb7da3).

Files with missing lines Patch % Lines
api/v1alpha1/validation/envoyproxy_validate.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7440      +/-   ##
==========================================
+ Coverage   72.29%   72.31%   +0.02%     
==========================================
  Files         232      232              
  Lines       34114    34104      -10     
==========================================
+ Hits        24662    24664       +2     
+ Misses       7676     7669       -7     
+ Partials     1776     1771       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain force-pushed the improv-validateClusterStatName branch from 9bb7f28 to 59dc4b0 Compare November 22, 2025 01:04
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the improv-validateClusterStatName branch from 59dc4b0 to 6cb7da3 Compare November 22, 2025 01:29
@zirain zirain requested a review from arkodg November 25, 2025 03:04
@arkodg arkodg added this to the v1.7.0-rc.1 Release milestone Nov 25, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team November 25, 2025 18:57
Copy link
Member

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be invalid ? %ROUTE_NAME%/%. Currently, this is treated as valid.

@zirain
Copy link
Member Author

zirain commented Nov 26, 2025

Should this be invalid ? %ROUTE_NAME%/%. Currently, this is treated as valid.

what is this used for?

@sudiptob2
Copy link
Member

Should this be invalid ? %ROUTE_NAME%/%. Currently, this is treated as valid.

what is this used for?

I see, not used just tried with this random string. I guess it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants