-
Notifications
You must be signed in to change notification settings - Fork 596
chore: improve validateClusterStatName #7440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a4868ee to
a382dd4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
==========================================
+ Coverage 72.29% 72.31% +0.02%
==========================================
Files 232 232
Lines 34114 34104 -10
==========================================
+ Hits 24662 24664 +2
+ Misses 7676 7669 -7
+ Partials 1776 1771 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9bb7f28 to
59dc4b0
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
59dc4b0 to
6cb7da3
Compare
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
sudiptob2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be invalid ? %ROUTE_NAME%/%. Currently, this is treated as valid.
what is this used for? |
I see, not used just tried with this random string. I guess it's not needed. |
Improve validateClusterStatName function,
%ROUTE_NAMEis invalid.