Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for TCP Route #737

Merged
merged 1 commit into from
Jan 6, 2023
Merged

feat: add support for TCP Route #737

merged 1 commit into from
Jan 6, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Nov 17, 2022 •
edited
Loading

Resolves: #643

Progress:

  • Xds IR
  • Xds Translator
  • Gateway API Translator
  • Provider
  • Docs

Signed-off-by: bitliu bitliu@tencent.com

@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 2 times, most recently from 69b3873 to d3f5f14 Compare November 17, 2022 18:36
@danehans
Copy link
Contributor

danehans commented Dec 5, 2022

@Xunzhuo are you able to complete this PR and the additional work to add TCPRoute support for v0.3.0-rc.1?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 6, 2022

Yes, it could be done possibly, I am quite busy this week, will come back to feature implementations this weekend.

@Xunzhuo Xunzhuo added area/api API-related issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/conformance Gateway API Conformance Related Issues labels Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #737 (c1deb92) into main (22131aa) will decrease coverage by 0.29%.
The diff coverage is 51.86%.

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   63.91%   63.61%   -0.30%     
==========================================
  Files          50       50              
  Lines        6506     6857     +351     
==========================================
+ Hits         4158     4362     +204     
- Misses       2087     2215     +128     
- Partials      261      280      +19
Impacted Files Coverage Δ
internal/gatewayapi/resource.go 56.66% <ø> (ø)
internal/gatewayapi/runner/runner.go 29.88% <0.00%> (-1.45%) ⬇️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/ir/infra.go 67.41% <ø> (ø)
internal/message/types.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/routes.go 26.63% <11.90%> (-3.07%) ⬇️
internal/provider/kubernetes/controller.go 46.65% <34.74%> (-0.89%) ⬇️
internal/xds/translator/translator.go 74.59% <43.47%> (-7.53%) ⬇️
internal/provider/kubernetes/predicates.go 59.78% <50.00%> (-0.44%) ⬇️
internal/gatewayapi/contexts.go 75.05% <71.05%> (-0.89%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo changed the title feat: add support for TCP Route feat(Gateway API Translator): add support for TCP Route Jan 3, 2023
@Xunzhuo Xunzhuo changed the title feat(Gateway API Translator): add support for TCP Route feat: add support for TCP Route Jan 3, 2023
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 2 times, most recently from 82f300d to 038e628 Compare January 3, 2023 04:10
@Xunzhuo Xunzhuo added the priority/high Label used to express the "high" priority level label Jan 3, 2023
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 6 times, most recently from ab54500 to 20d7de5 Compare January 3, 2023 07:28
@Xunzhuo Xunzhuo added this to the 0.3.0-rc.1 milestone Jan 3, 2023
@Xunzhuo Xunzhuo marked this pull request as ready for review January 3, 2023 07:29
@Xunzhuo Xunzhuo requested a review from a team as a code owner January 3, 2023 07:29
@Xunzhuo Xunzhuo force-pushed the feat-tcp-route branch 3 times, most recently from 98843ab to c1deb92 Compare January 3, 2023 10:39
arkodg
arkodg reviewed Jan 3, 2023
View reviewed changes
docs/latest/user/tcp-routing.md

You can try to use nc to test the TCP connections of envoy gateway with different ports, and you can see them succeeded:

```shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand a little more for this example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand this with an additional docs PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure np

@Xunzhuo
feat: add support for TCP Route
fafa4aa 
Signed-off-by: bitliu <bitliu@tencent.com>
arkodg
arkodg approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this feature in @Xunzhuo 🚀 !

@arkodg arkodg merged commit 9c1645a into envoyproxy:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain left review comments

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
area/api API-related issues area/conformance Gateway API Conformance Related Issues area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. priority/high Label used to express the "high" priority level
Projects
None yet
Milestone
0.3.0-rc.1
Development

Successfully merging this pull request may close these issues.

Add Support for TCPRoute API
5 participants
@Xunzhuo @danehans @codecov-commenter @zirain @arkodg