Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global rate limit infra components #723

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 11, 2022

  • RateLimitInfraIR - holds the config to manage the ratelimit service.
  • global-ratelimit runner that subscribes to XdsIR messages and translates it to RateLimitInfraIR.
  • enhance the infrastructure runner to subscribe to RateLimitInfraIR messages and translate it into platform specific ratelimit resources.

Relates to #670

Signed-off-by: Arko Dasgupta arko@tetrate.io

@arkodg arkodg requested a review from a team as a code owner November 11, 2022 00:27
@arkodg arkodg marked this pull request as draft November 11, 2022 00:27
@arkodg arkodg force-pushed the global-ratelimit-infra branch 3 times, most recently from b1fe9c4 to 4050195 Compare November 11, 2022 00:48
@arkodg arkodg changed the title Global rate limit components Global rate limit infra components Nov 11, 2022
@arkodg arkodg added this to the 0.3.0-rc.1 milestone Nov 11, 2022
@arkodg
Copy link
Contributor Author

arkodg commented Nov 15, 2022

envoyproxy/ratelimit#374 should unblock this PR and we should be able to reuse the config structure from upstream

@arkodg
Copy link
Contributor Author

arkodg commented Nov 17, 2022

now blocked on #726 which updates the Xds IR with a rate limit definition

@arkodg arkodg mentioned this pull request Dec 5, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 17, 2022
* `RateLimitInfraIR` - holds the config to manage
the ratelimit service.
* `global-ratelimit` runner that subscribes to `XdsIR` messages
and translates it to `RateLimitInfraIR`.
* enhance the `infrastructure` runner to subscribe to `RateLimitInfraIR`
messages and translate it into platform specific ratelimit resources.

Relates to envoyproxy#670

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as ready for review January 18, 2023 22:11
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg removed the stale label Jan 18, 2023
@arkodg arkodg requested a review from danehans January 23, 2023 21:39
@arkodg arkodg merged commit 84044da into envoyproxy:main Jan 24, 2023
@arkodg arkodg deleted the global-ratelimit-infra branch January 24, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants