Skip to content

support TCPRoute Authz in xDS translator #7184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2025
Merged

support TCPRoute Authz in xDS translator #7184

merged 3 commits into from
Oct 18, 2025

Conversation

@arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 9, 2025

Relates to #4908

@arkodg arkodg requested a review from a team as a code owner October 9, 2025 23:26
@arkodg arkodg marked this pull request as draft October 9, 2025 23:26
@davem-git davem-git mentioned this pull request Oct 13, 2025
Merged
davem-git
davem-git reviewed Oct 14, 2025
View reviewed changes
davem-git
davem-git reviewed Oct 14, 2025
View reviewed changes
internal/xds/translator/listener.go
return nil, err
}

if authzFilter, err := buildTCPRBACFilter(statPrefix, irRoute.Authorization); err != nil {

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@davem-git davem-git mentioned this pull request Oct 15, 2025
Merged
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.59259% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.11%. Comparing base (70af785) to head (1a8643c).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/authorization_tcp.go 72.41% 16 Missing and 8 partials ⚠️
internal/xds/translator/listener.go 72.91% 7 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7184      +/-   ##
==========================================
+ Coverage   71.07%   71.11%   +0.04%     
==========================================
  Files         228      229       +1     
  Lines       40825    40927     +102     
==========================================
+ Hits        29015    29104      +89     
- Misses      10104    10110       +6     
- Partials     1706     1713       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg marked this pull request as ready for review October 16, 2025 00:29
zhaohuabing
zhaohuabing approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Arko Dasgupta added 3 commits October 16, 2025 22:55
@zhaohuabing
support TCPRoute Authz in xDS translator
beb043d 
Relates to envoyproxy#4908

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zhaohuabing
test
6d4e90a 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zhaohuabing
make generate
1a8643c 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested review from a team October 17, 2025 00:31
@kkk777-7
Copy link
Member

kkk777-7 commented Oct 18, 2025

LGTM, thanks!

@arkodg arkodg merged commit 77655cb into envoyproxy:main Oct 18, 2025
71 of 78 checks passed
@arkodg arkodg deleted the rbac-tcp branch October 18, 2025 01:46
aburan28 pushed a commit to aburan28/gateway that referenced this pull request Oct 18, 2025
@arkodg @davem-git @aburan28
support TCPRoute Authz in xDS translator (envoyproxy#7184)
317f27c 
* support TCPRoute Authz in xDS translator

Relates to envoyproxy#4908

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: davem-git <demathieu@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@kkk777-7 kkk777-7 kkk777-7 approved these changes

+1 more reviewer

@davem-git davem-git davem-git approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arkodg @kkk777-7 @zhaohuabing @davem-git