Skip to content

fix(logging): correct log formatting to avoid DPANIC in controller-runtime logger #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2025
Merged

fix(logging): correct log formatting to avoid DPANIC in controller-runtime logger #6846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f34ea57
Update filters.go
TomerJLevy Aug 25, 2025
4dcf3d5
Merge branch 'main' into patch-1
TomerJLevy Aug 27, 2025
f0ce999
add release notes
TomerJLevy Aug 27, 2025
3f248c0
Merge branch 'main' into patch-1
TomerJLevy Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/provider/kubernetes/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (r *gatewayAPIReconciler) getExtensionRefFilters(ctx context.Context) ([]un
uExtResourceList := &unstructured.UnstructuredList{}
uExtResourceList.SetGroupVersionKind(gvk)
if err := r.client.List(ctx, uExtResourceList); err != nil {
r.log.Info("no associated resources found for %s", gvk.String())
r.log.Info("no associated resources found", "GVK", gvk.String())
return nil, fmt.Errorf("failed to list %s: %w", gvk.String(), err)
}

Expand Down Expand Up @@ -57,7 +57,7 @@ func (r *gatewayAPIReconciler) getExtensionBackendResources(ctx context.Context)
uExtResourceList := &unstructured.UnstructuredList{}
uExtResourceList.SetGroupVersionKind(gvk)
if err := r.client.List(ctx, uExtResourceList); err != nil {
r.log.Info("no associated backend resources found for %s", gvk.String())
r.log.Info("no associated backend resources found", "GVK", gvk.String())
return nil, fmt.Errorf("failed to list %s: %w", gvk.String(), err)
}

Expand Down
1 change: 1 addition & 0 deletions release-notes/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ bug fixes: |
Fixed %ROUTE_KIND% operator to be lower-cased when used by clusterStatName in EnvoyProxy API.
Fixed maxAcceptPerSocketEvent being ignored in ClientTrafficPolicy
Fixed the topologyInjectorDisabled and the local cluster was not defined.
Fixed log formatting of improper key-value pairs to avoid DPANIC in controller-runtime logger.

# Enhancements that improve performance.
performance improvements: |
Expand Down