Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Aug 7, 2025

fixes: #6716

zirain added 2 commits August 7, 2025 09:21
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain added this to the v1.5.0 Release milestone Aug 7, 2025
@zirain zirain requested a review from a team as a code owner August 7, 2025 02:03
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.03%. Comparing base (14a02b0) to head (cf150e8).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6722      +/-   ##
==========================================
+ Coverage   71.00%   71.03%   +0.02%     
==========================================
  Files         224      224              
  Lines       39606    39618      +12     
==========================================
+ Hits        28122    28141      +19     
+ Misses       9824     9818       -6     
+ Partials     1660     1659       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Kind: "GatewayClass",
Name: t.GatewayClass.Name,
Annotations: filterEGPrefix(t.GatewayClass.Annotations),
SectionName: string(listener.Name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause the same issue as before, because merging listeners, will end up creating new resource metadata since you are adding a section name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/gatewayapi/testdata/merge-valid-multiple-gateways2.in.yaml show a stable xds when they use same section.

@zirain
Copy link
Member Author

zirain commented Aug 7, 2025

#6639 reverted, closed.

@zirain zirain closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Websocket is disconnected when creating/removing unrelated gateways with mergeGateways mode

3 participants