fix: nil pointer when InsecureSkipVerify is true #6652

zhaohuabing · 2025-07-31T05:48:43Z

codecov · 2025-07-31T05:57:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.07%. Comparing base (8d32d0f) to head (b596eba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6652      +/-   ##
==========================================
- Coverage   71.09%   71.07%   -0.02%     
==========================================
  Files         225      225              
  Lines       39508    39509       +1     
==========================================
- Hits        28087    28080       -7     
- Misses       9804     9811       +7     
- Partials     1617     1618       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zirain · 2025-07-31T07:34:46Z

do we have test for this?

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing · 2025-07-31T08:17:05Z

do we have test for this?

There is one with BackendTLSPolicy, add one to cover the case without BackendTLSPolicy.

zirain · 2025-07-31T08:54:03Z

do we have test for this?

There is one with BackendTLSPolicy, add one to cover the case without BackendTLSPolicy.

Is there no guarantee of testing about translator?

zhaohuabing · 2025-07-31T11:06:30Z

Is there no guarantee of testing about translator?

There is one in the xds translator tests, but it also has CACertificate in the tls configuration.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * add test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * add test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com>

* chore: cleanups from #6597 (#6647) Cleanup Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: set order for grpc_web and grpc_stats filters (#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: nil pointer when InsecureSkipVerify is true (#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * add test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: allow imageRepository contains port (#6658) (#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: 聪 <congwu@alauda.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: improve policy concepts section (#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: observability pre req not required in admin console page (#6662) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: xds name scheme v2 (#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: highlight wait step (#6665) * docs: highlight wait step Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> * fix: populate status for custom backendRef not found (#6670) Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: xds name schema v2 (#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: expand Gateway Namespace Mode doc on client/server auth (#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * increase earlyRequestHeaders from 16 to 64 (#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: skipping TLS verification (#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove public Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * feat: add listener metadata (#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove sort Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: Fix BTP ZoneAware translation (#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add e2e Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: unhide zoneaware api for docs (#6683) unhide api docs Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * watchable: use Store directly instead of HandleStore wrapper (#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to #6406 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix test Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (#6667) Update zone aware routing docs Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * combine the xds-translator and xds-server runner into one (#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * build(deps): bump the gomod group across 1 directory with 6 updates (#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <support@github.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: controller panic when reloading config (#6688) * fix controller panic when reloading config Signed-off-by: zirain <zirain2009@gmail.com> * use gwapiv1.Duration instead of metav1.Duration (#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: #4746 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * add charts Signed-off-by: Arko Dasgupta <arko@tetrate.io> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <zirain2009@gmail.com> * [release/v1.5] release notes for rc.2 (#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Isaac <10012479+jukie@users.noreply.github.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: 聪 <congwu@alauda.io> Co-authored-by: Xunzhuo <bitliu@tencent.com> Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: cleanups from envoyproxy#6597 (envoyproxy#6647) Cleanup Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: set order for grpc_web and grpc_stats filters (envoyproxy#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: nil pointer when InsecureSkipVerify is true (envoyproxy#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * add test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: allow imageRepository contains port (envoyproxy#6658) (envoyproxy#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: 聪 <congwu@alauda.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: improve policy concepts section (envoyproxy#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: observability pre req not required in admin console page (envoyproxy#6662) Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: xds name scheme v2 (envoyproxy#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: highlight wait step (envoyproxy#6665) * docs: highlight wait step Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> * fix: populate status for custom backendRef not found (envoyproxy#6670) Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: xds name schema v2 (envoyproxy#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: expand Gateway Namespace Mode doc on client/server auth (envoyproxy#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * increase earlyRequestHeaders from 16 to 64 (envoyproxy#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: skipping TLS verification (envoyproxy#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove public Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * feat: add listener metadata (envoyproxy#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> * remove sort Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: Fix BTP ZoneAware translation (envoyproxy#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> * Add e2e Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * docs: unhide zoneaware api for docs (envoyproxy#6683) unhide api docs Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * watchable: use Store directly instead of HandleStore wrapper (envoyproxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix test Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (envoyproxy#6667) Update zone aware routing docs Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> * combine the xds-translator and xds-server runner into one (envoyproxy#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * build(deps): bump the gomod group across 1 directory with 6 updates (envoyproxy#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <support@github.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: controller panic when reloading config (envoyproxy#6688) * fix controller panic when reloading config Signed-off-by: zirain <zirain2009@gmail.com> * use gwapiv1.Duration instead of metav1.Duration (envoyproxy#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: envoyproxy#4746 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * add charts Signed-off-by: Arko Dasgupta <arko@tetrate.io> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <zirain2009@gmail.com> * [release/v1.5] release notes for rc.2 (envoyproxy#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Isaac <10012479+jukie@users.noreply.github.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: 聪 <congwu@alauda.io> Co-authored-by: Xunzhuo <bitliu@tencent.com> Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: zirain <zirain2009@gmail.com>

zhaohuabing requested a review from a team as a code owner July 31, 2025 05:48

zirain previously approved these changes Jul 31, 2025

View reviewed changes

fix nil pointer when InsecureSkipVerify is true

0e3bcca

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing dismissed zirain’s stale review via 0e3bcca July 31, 2025 06:02

zhaohuabing force-pushed the fix-6651 branch from fcb34b9 to 0e3bcca Compare July 31, 2025 06:02

zhaohuabing requested a review from zirain July 31, 2025 06:03

add test

0a64060

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

cnvergence previously approved these changes Jul 31, 2025

View reviewed changes

delete cacert for the xds translator test

b596eba

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing dismissed cnvergence’s stale review via b596eba July 31, 2025 11:13

zhaohuabing requested a review from cnvergence July 31, 2025 11:13

zhaohuabing added this to the v1.5.0 Release milestone Jul 31, 2025

cnvergence approved these changes Jul 31, 2025

View reviewed changes

arkodg approved these changes Jul 31, 2025

View reviewed changes

arkodg merged commit aaee75f into envoyproxy:main Jul 31, 2025
49 of 51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: nil pointer when InsecureSkipVerify is true #6652

fix: nil pointer when InsecureSkipVerify is true #6652

Uh oh!

zhaohuabing commented Jul 31, 2025

Uh oh!

codecov bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

zirain commented Jul 31, 2025

Uh oh!

zhaohuabing commented Jul 31, 2025

Uh oh!

zirain commented Jul 31, 2025

Uh oh!

zhaohuabing commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: nil pointer when InsecureSkipVerify is true #6652

fix: nil pointer when InsecureSkipVerify is true #6652

Uh oh!

Conversation

zhaohuabing commented Jul 31, 2025

Uh oh!

codecov bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zirain commented Jul 31, 2025

Uh oh!

zhaohuabing commented Jul 31, 2025

Uh oh!

zirain commented Jul 31, 2025

Uh oh!

zhaohuabing commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 31, 2025 •

edited

Loading