fix: add missing HTTP filters for HTTP3 listener #6584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6584 +/- ##
==========================================
+ Coverage 70.86% 71.01% +0.15%
==========================================
Files 224 225 +1
Lines 38769 38933 +164
==========================================
+ Hits 27472 27647 +175
+ Misses 9708 9684 -24
- Partials 1589 1602 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
thanks @zhaohuabing does this solve #5660 ? |
arkodg
reviewed
Jul 23, 2025
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
fix-http3-listener-filter
branch
from
bd49e4c to
d3a2e28
Compare
Member
Author
Not sure - it looks like a different issue. |
zirain
approved these changes
Jul 24, 2025
arkodg
approved these changes
Jul 25, 2025
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Aug 11, 2025
* fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Aug 11, 2025
* fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
added a commit
that referenced
this pull request
Aug 11, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <zirain2009@gmail.com> * sort httpFilters on name if priority order is same (#6600) * sort httpFilters on name if priority order is same ensures stability across translations, mitigating listener drains https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * fix: add missing HTTP filters for HTTP3 listener (#6584) * fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: use per-route configuration for session persistence to avoid listener drain (#6580) use per-route configuration for session persistence to avoid listener darin Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: #6559 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
shawnh2
pushed a commit
to shawnh2/gateway
that referenced
this pull request
Sep 15, 2025
* fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <zirain2009@gmail.com> * sort httpFilters on name if priority order is same (envoyproxy#6600) * sort httpFilters on name if priority order is same ensures stability across translations, mitigating listener drains https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/listeners/listener_filters#filter-chain-only-update Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> * fix: add missing HTTP filters for HTTP3 listener (envoyproxy#6584) * fix: add missing HTTP filters for HTTP3 listener Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * fix: use per-route configuration for session persistence to avoid listener drain (envoyproxy#6580) use per-route configuration for session persistence to avoid listener darin Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen (envoyproxy#6560) * Fix EEP CEL Validations around FullDuplexStreamed and FailOpen Fixes: envoyproxy#6559 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP filters are missing in the UDP listener when HTTP3 is enabled and multiple listeners are on the same port.
Fixes #6544 (comment)