-
Notifications
You must be signed in to change notification settings - Fork 526
chore: fix wasm file cache directory permission #6173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix wasm file cache directory permission #6173
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
=======================================
Coverage 70.47% 70.48%
=======================================
Files 220 220
Lines 36625 36625
=======================================
+ Hits 25811 25814 +3
+ Misses 9284 9283 -1
+ Partials 1530 1528 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
0660/0770 won't work because
|
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
9294b4c
to
a227953
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
|
||
// we don't set the envoy-gateway deployment security context user id back to default because this will | ||
// cause the envoy proxies failed to be deleted after the Gateway resources in the base are deleted. | ||
// This is acceptable because this won't affect the later tests in the same suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens because the Envoy Gateway may lose the deletion message of Gateways while rollout restart, and the left Envoy proxies cause failure of the upgrade test.
This is an edge case found in this test - should EG proactively delete the Envoy proxies that are orphaned after Gateways are removed?
Manually delete the Envoy proxies after the test.
Related issue: #3051
https://github.com/envoyproxy/gateway/actions/runs/15431221218/job/43429760632?pr=6173
➜ gateway git:(fix-cache-permission) ✗ k -n envoy-gateway-system get pod -w
NAME READY STATUS RESTARTS AGE
envoy-gateway-79df56475-946vz 1/1 Running 0 29s
envoy-gateway-conformance-infra-all-namespaces-302def45-5dj9bxt 1/2 Running 0 42s
envoy-gateway-conformance-infra-same-namespace-9baff503-69cchq4 1/2 Running 0 42s
0d6b97f
to
30b36fc
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
30b36fc
to
73cd33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the e2e
This reverts commit 73cd33c.
* fix wasm file cache directory permission Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
This PR makes
/var/lib/eg
writable for any user. This allows the EG process to write Wasm cache into this directory when the UID has been changed by the Pod/Container SecurityContext.Fixes: #5819 (comment)