Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Secure Gateway User Doc #542

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Adds Secure Gateway User Doc #542

merged 8 commits into from
Oct 21, 2022

Conversation

danehans
Copy link
Contributor

Adds a user doc for configuring Gateway TLS termination.

Signed-off-by: danehans daneyonhansen@gmail.com

@danehans danehans added the documentation Improvements or additions to documentation label Oct 11, 2022
@danehans danehans added this to the 0.2.0 milestone Oct 11, 2022
@danehans danehans requested a review from a team as a code owner October 11, 2022 20:21
@danehans
Copy link
Contributor Author

danehans commented Oct 11, 2022 •
edited
Loading

/hold until v0.2.0 release branch is cut.

@danehans danehans marked this pull request as draft October 11, 2022 20:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #542 (ddfdc88) into main (ba27f64) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   62.05%   61.98%   -0.07%     
==========================================
  Files          47       47              
  Lines        5737     5737              
==========================================
- Hits         3560     3556       -4     
- Misses       1948     1952       +4     
  Partials      229      229
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 73.91% <0.00%> (-6.53%) ⬇️
internal/provider/kubernetes/tlsroute.go 56.38% <0.00%> (-3.09%) ⬇️
internal/provider/kubernetes/gateway.go 51.59% <0.00%> (+0.85%) ⬆️
internal/provider/kubernetes/gatewayclass.go 73.18% <0.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans danehans mentioned this pull request Oct 11, 2022
Closed
@skriss skriss mentioned this pull request Oct 12, 2022
Closed
@danehans danehans force-pushed the secure_gateway_docs branch 3 times, most recently from ebb8abf to 9b43e60 Compare October 14, 2022 20:57
chauhanshubham
chauhanshubham previously approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@chauhanshubham chauhanshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Xunzhuo
Xunzhuo previously approved these changes Oct 15, 2022
View reviewed changes
@danehans danehans dismissed stale reviews from Xunzhuo and chauhanshubham via fd7a591 October 15, 2022 17:08
@danehans
Copy link
Contributor Author

Removing "Draft" since #571 adds .md support.

@danehans danehans marked this pull request as ready for review October 15, 2022 18:54
This was referenced Oct 16, 2022
Merged
Closed
@danehans
Copy link
Contributor Author

CI failure is due to Codecov upload, rerunning.

@danehans
Copy link
Contributor Author

danehans commented Oct 17, 2022 •
edited
Loading

Commit 1bae79a is a rebase since #572 added markdown linting.

skriss
skriss suggested changes Oct 17, 2022
View reviewed changes
docs/user/SECURE_GATEWAY.md Outdated Show resolved Hide resolved
examples/kubernetes/quickstart.yaml Outdated Show resolved Hide resolved
LukeShu
LukeShu reviewed Oct 17, 2022
View reviewed changes
docs/user/secure-gateways.md Outdated Show resolved Hide resolved
docs/user/secure-gateways.md Show resolved Hide resolved
docs/user/secure-gateways.md Outdated Show resolved Hide resolved
docs/user/secure-gateways.md Outdated Show resolved Hide resolved
docs/user/secure-gateways.md Outdated Show resolved Hide resolved
docs/user/secure-gateways.md Outdated Show resolved Hide resolved
@danehans danehans force-pushed the secure_gateway_docs branch 2 times, most recently from 19336da to f958fb3 Compare October 18, 2022 04:44
@danehans danehans mentioned this pull request Oct 18, 2022
Closed
@danehans
Copy link
Contributor Author

I'm marking this PR as a Draft until we figure out the best course of action for #588.

@danehans danehans marked this pull request as draft October 18, 2022 17:40
@danehans danehans mentioned this pull request Oct 18, 2022
Closed
@danehans danehans mentioned this pull request Oct 19, 2022
Merged
@danehans danehans marked this pull request as ready for review October 19, 2022 18:37
@danehans
Copy link
Contributor Author

Moving to v0.3.0-rc.1 since docs can be added post-v0.2.0.

@danehans danehans modified the milestones: 0.2.0, 0.3.0-rc.1 Oct 19, 2022
@danehans
Adds Secure Gateway User Doc
eb7e61e 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Refs Quickstart for Install/Uninstall Steps
701d728 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Adds generated TLS assets to gitignore
72161ae 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Adds Cross Namespace and Multiple Listeners
bb90239 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Fixes Markdown Lint Errors
b538d20 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Updates port forwarding for hashed naming
9e5c6d7 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Adds kubectl patch for adding https listener
ab22514 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans
Updates multi and cross ns cert sections
bf099cc 
Signed-off-by: danehans <daneyonhansen@gmail.com>
skriss
skriss approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run through this all successfully.

Two little nits that you can choose to address or ignore.

@danehans danehans merged commit d572c23 into envoyproxy:main Oct 21, 2022
danehans added a commit to danehans/gateway that referenced this pull request Nov 3, 2022
@danehans
Adds Secure Gateway User Doc (envoyproxy#542)
15cc411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeShu LukeShu LukeShu left review comments

@chauhanshubham chauhanshubham chauhanshubham left review comments

@skriss skriss skriss approved these changes

@Xunzhuo Xunzhuo Xunzhuo left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.0-rc.1
Development

Successfully merging this pull request may close these issues.
6 participants
@danehans @codecov-commenter @LukeShu @skriss @chauhanshubham @Xunzhuo