Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Infra IR Port Naming #518

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Updates Infra IR Port Naming #518

merged 1 commit into from
Oct 7, 2022

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 7, 2022

Appends the Gateway listener name to the Infra IR port naming convention.

Fixes #517

Signed-off-by: danehans daneyonhansen@gmail.com

@danehans danehans requested a review from a team as a code owner October 7, 2022 17:06
@danehans danehans added area/ir Issues related to Gateway's internal representation, e.g. data model. provider/kubernetes Issues related to the Kubernetes provider area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. and removed provider/kubernetes Issues related to the Kubernetes provider labels Oct 7, 2022
@danehans danehans added this to the 0.2.0 milestone Oct 7, 2022
@chauhanshubham
Copy link
Member

chauhanshubham commented Oct 7, 2022 •
edited
Loading

Thanks.
I was actually updating the port naming as part of #402
But I was adding the port number instead of the name. so please ignore my changes, will rebase my PR with yours once this gets merged.

@danehans
Copy link
Contributor Author

danehans commented Oct 7, 2022

@arkodg 491c05a resolves #518 (comment) by using the Gateway listener name for the infra IR port name.

arkodg
arkodg previously approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danehans
Updates Infra IR Port Naming
1780a6f 
Signed-off-by: danehans <daneyonhansen@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #518 (1780a6f) into main (c4fbdc0) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   62.51%   62.70%   +0.18%     
==========================================
  Files          42       42              
  Lines        4498     4496       -2     
==========================================
+ Hits         2812     2819       +7     
+ Misses       1540     1533       -7     
+ Partials      146      144       -2
Impacted Files Coverage Δ
internal/gatewayapi/translator.go 91.16% <100.00%> (-0.02%) ⬇️
internal/provider/kubernetes/gatewayclass.go 70.28% <0.00%> (+1.44%) ⬆️
internal/provider/kubernetes/gateway.go 73.10% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chauhanshubham
chauhanshubham approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@chauhanshubham chauhanshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@danehans danehans merged commit bbb89c9 into envoyproxy:main Oct 7, 2022
@danehans danehans deleted the issue_517 branch October 7, 2022 21:23
@arkodg arkodg mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@chauhanshubham chauhanshubham chauhanshubham approved these changes

Assignees
No one assigned
Labels
area/ir Issues related to Gateway's internal representation, e.g. data model. area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Infra Manager Unable to Create Service When Gateway Has Multiple Ports
4 participants
@danehans @chauhanshubham @codecov-commenter @arkodg