Consolidates Quickstart Manifests #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danehans <daneyonhansen@gmail.com>
|
Note: The quickstart guide must be updated to use the |
danehans
added
documentation
Alice-Lilith
approved these changes
Oct 10, 2022
LukeShu
approved these changes
Oct 11, 2022
Comment on lines
+64
to
73
| kubectl apply -f examples/kubernetes/quickstart.yaml | ||
| @echo "\nPort forward to the Envoy service using the command below" | ||
| @echo "kubectl -n envoy-gateway-system port-forward service/envoy-default-eg 8888:8080 &" | ||
| @echo "\nCurl the app through Envoy proxy using the command below" | ||
| @echo "curl --verbose --header \"Host: www.example.com\" http://localhost:8888/get\n" | ||
|
|
||
| .PHONY: kube-demo-undeploy | ||
| kube-demo-undeploy: ## Uninstall the Kubernetes resources installed from the `make kube-demo` command. | ||
| kubectl delete -f examples/kubernetes/httproute.yaml | ||
| kubectl delete -f examples/kubernetes/gateway.yaml | ||
| kubectl delete -f examples/kubernetes/gatewayclass.yaml | ||
| kubectl delete -f examples/kubernetes/httpbin.yaml | ||
| kubectl delete -f examples/kubernetes/quickstart.yaml | ||
|
|
There was a problem hiding this comment.
Just to call it out: The order of these is changing. (The new order is gatewayclass.yaml, gateway.yaml, httpbin.yaml, httproute.yaml)
I don't think that matters, but I figured it should be said explicitly.
There was a problem hiding this comment.
@LukeShu thanks for making this point. Although the order changes, I have verified that all the created resources are removed without error.
Closed
danehans
added a commit
to danehans/gateway
that referenced
this pull request
Nov 3, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release-manifeststarget to post the quickstart manifests as a release artifact. This allows for released versions of quickstart manifests from the quickstart guide.quickstart.yaml.kube-demoandkube-demo-undeploytargets to usequickstart.yaml.Fixes: #484
Signed-off-by: danehans daneyonhansen@gmail.com