Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dump #4593

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: remove dump #4593

merged 1 commit into from
Oct 31, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 31, 2024

The root cause is clear, it's fine to remove this, which make the log smaller and clear to view.

cc @zhaohuabing

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner October 31, 2024 10:38
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.50%. Comparing base (74f4377) to head (90e7b8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4593      +/-   ##
==========================================
+ Coverage   65.47%   65.50%   +0.03%     
==========================================
  Files         211      211              
  Lines       31854    31854              
==========================================
+ Hits        20855    20867      +12     
+ Misses       9754     9744      -10     
+ Partials     1245     1243       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg merged commit efe625d into envoyproxy:main Oct 31, 2024
24 checks passed
@zirain zirain deleted the clean-dump branch October 31, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants