[WIP] Enable IPv6 first cluster test #4590
Open
+3,779
−1,342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4590 +/- ##
==========================================
+ Coverage 65.47% 65.48% +0.01%
==========================================
Files 211 212 +1
Lines 31854 31918 +64
==========================================
+ Hits 20855 20903 +48
- Misses 9754 9770 +16
Partials 1245 1245 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <zirain2009@gmail.com>
|
@zirain should this be in v1.2.0 ? |
therer're a lot of pending PRs that block this one. |
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
commented
Oct 31, 2024
| IPFamily: net.PreferIPFamily(ipv6First, infra.Config), | ||
| } | ||
|
|
||
| // TODO: this's a temporary solution to support IPv6 first cluster for Envoy Gateway. |
There was a problem hiding this comment.
Remind myself not to forget to send a separate PR with modification here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, use CI to test some pending PRs together.