Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses #4587

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+359 −11

fix lint

fce855d
Select commit
Loading
Failed to load commit list.
Open

fix: HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses #4587

fix lint
fce855d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2024 in 0s

65.46% (target 60.00%)

View this Pull Request on Codecov

65.46% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.46%. Comparing base (74f4377) to head (fce855d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/status.go 77.55% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4587      +/-   ##
==========================================
- Coverage   65.47%   65.46%   -0.01%     
==========================================
  Files         211      211              
  Lines       31854    31925      +71     
==========================================
+ Hits        20855    20901      +46     
- Misses       9754     9780      +26     
+ Partials     1245     1244       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov