Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update configuration kick in tips #4479

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 18, 2024

fixes: #4471

xref: #4451

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner October 18, 2024 13:37
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Contributor Author

zirain commented Oct 18, 2024

preview:

image

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.80%. Comparing base (70c568b) to head (d56fdfb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
- Coverage   65.81%   65.80%   -0.01%     
==========================================
  Files         203      203              
  Lines       30699    30699              
==========================================
- Hits        20204    20201       -3     
- Misses       9341     9344       +3     
  Partials     1154     1154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor Author

zirain commented Oct 18, 2024

/retest

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested review from a team October 20, 2024 02:58
@zhaohuabing zhaohuabing merged commit 26ec49a into envoyproxy:main Oct 21, 2024
27 checks passed
@zirain zirain deleted the docs/remove-rollout branch October 21, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remember to delete all the rollout commands in the docs
3 participants