-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect release note in each PR #4473
Conversation
it would be better to have linter for this. |
Not every PR needs to modify the release note. We can add that later if needed. Checking when reviewing the PR can help solving the current issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
==========================================
- Coverage 65.97% 65.96% -0.01%
==========================================
Files 203 203
Lines 31154 31154
==========================================
- Hits 20554 20551 -3
- Misses 9415 9418 +3
Partials 1185 1185 ☔ View full report in Codecov by Sentry. |
thanks @zhaohuabing the workflow looks great. I was hoping we can revisit the Release Notes format, right now its focused on changes for a specific area, my preference would be to describe the change in terms of the feature being added or bug being fixed, wdyt @envoyproxy/gateway-maintainers , there's enough past work in this space we can get inspiration from |
@arkodg Good point! The current format follows Envoy, which makes sense for it as most peoploe working on envoy are developers, and they need to know the technical details of the changes. However, I believe we should reorganize EG's changelog to better algin with the end users' perspective. As an end user, I would expect to see the following sections in the changelog:
Minor tasks, such as improvement of CI or fixes for flaky tests, don't need to be included in the changelog. |
hey @zhaohuabing +1 to the proposed format |
also additional sections called |
f8e830d
to
98b8ef8
Compare
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
98b8ef8
to
85e7eb4
Compare
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Fix #4472