-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): implement httproutefilter host rewrite #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guydc
force-pushed
the
impl-host-rewrite
branch
from
October 14, 2024 12:43
2904511
to
016dd28
Compare
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
impl-host-rewrite
branch
from
October 14, 2024 12:48
016dd28
to
377f554
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
==========================================
+ Coverage 66.01% 66.05% +0.04%
==========================================
Files 203 203
Lines 31154 31238 +84
==========================================
+ Hits 20566 20635 +69
- Misses 9407 9417 +10
- Partials 1181 1186 +5 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Oct 14, 2024
zirain
reviewed
Oct 14, 2024
zhaohuabing
reviewed
Oct 15, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
zirain
previously approved these changes
Oct 22, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
zirain
approved these changes
Oct 22, 2024
arkodg
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3173, #4410