Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): implement httproutefilter host rewrite #4446

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Oct 14, 2024

What type of PR is this?

What this PR does / why we need it:

  • Updates API to format requested in api: host header rewrite #4410
  • Implements host rewrite based on custom header and backend dns name
  • E2E and docs
  • Fix Regex Path rewrite docs and translation bug

Which issue(s) this PR fixes:

Fixes #3173, #4410

@guydc guydc requested a review from a team as a code owner October 14, 2024 12:34
Signed-off-by: Guy Daich <guy.daich@sap.com>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 95.94595% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (a5c3cd2) to head (b794fc4).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/ir/xds.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4446      +/-   ##
==========================================
+ Coverage   66.01%   66.05%   +0.04%     
==========================================
  Files         203      203              
  Lines       31154    31238      +84     
==========================================
+ Hits        20566    20635      +69     
- Misses       9407     9417      +10     
- Partials     1181     1186       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/v1alpha1/httproutefilter_types.go Outdated Show resolved Hide resolved
api/v1alpha1/httproutefilter_types.go Outdated Show resolved Hide resolved
api/v1alpha1/httproutefilter_types.go Outdated Show resolved Hide resolved
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@arkodg arkodg added this to the v1.2.0-rc1 milestone Oct 22, 2024
zirain
zirain previously approved these changes Oct 22, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
@arkodg arkodg merged commit 8b8884d into envoyproxy:main Oct 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional host rewrite options
4 participants