chore: remove redundant helm-package command
#3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
- Coverage 68.16% 68.11% -0.05%
==========================================
Files 167 167
Lines 20370 20370
==========================================
- Hits 13885 13875 -10
- Misses 5485 5492 +7
- Partials 1000 1003 +3 ☔ View full report in Codecov by Sentry. |
|
/retest |
zirain
approved these changes
Jun 5, 2024
arkodg
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The
make helm-pushalready relys onmake helm-package, remove redundant command.gateway/tools/make/helm.mk
Line 39 in 607d8bc
Which issue(s) this PR fixes:
Fixes #