feat: support custom names for generated k8s resources

[arkodg]

Relates to #3527

[codecov]

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (607d8bc) to head (767b10e).
Report is 7 commits behind head on main.

Files	Patch %	Lines
internal/gatewayapi/helpers.go	0.00%	4 Missing ⚠️
internal/provider/kubernetes/predicates.go	77.77%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3537      +/-   ##
==========================================
+ Coverage   68.16%   68.18%   +0.02%     
==========================================
  Files         167      168       +1     
  Lines       20370    20408      +38     
==========================================
+ Hits        13885    13915      +30     
- Misses       5485     5493       +8     
  Partials     1000     1000              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cnvergence]

probably we would need to also change it in kubernetes provider

gateway/internal/provider/kubernetes/helpers.go

Line 151 in 607d8bc

func infraName(gateway *gwapiv1.Gateway, merged bool) string {

[arkodg]

hey @cnvergence can you elaborate why thats needed, the above diff is changing the value right before setting the resource name ?

[arkodg]

oh @cnvergence I see the issue now, we are fetching based on name and not labels 😢

gateway/internal/provider/kubernetes/predicates.go

Line 467 in cdd4e06

key := types.NamespacedName{

&

gateway/internal/provider/kubernetes/predicates.go

Line 483 in cdd4e06

key := types.NamespacedName{

cc @dprotaso this is the issue seen in knative-extensions/net-gateway-api#738

[cnvergence]

🚀

[cnvergence]

LGTM

[davem-git]

If this is addressed here, will it also fix when I rename the envoyDeployment:, the HPA envoyHpa? It no longer works it keeps the original generated name. There doesn't seem to be a way to patch that either

[arkodg]

If this is addressed here, will it also fix when I rename the envoyDeployment:, the HPA envoyHpa? It no longer works it keeps the original generated name. There doesn't seem to be a way to patch that either

thanks for catching this ! ive fixed the deployment targetRef naming in hpa.
I havent changed the name on the hpa resource itself, that needs an API change, which can be handled in a future PR

[zhaohuabing]

🚀

[davem-git]

On this same issue. I've renamed the deployment by patching the name, this causes the gateway to break. While the deployment with 3 replicas I get this error

  Last Transition Time:  2024-06-14T15:02:58Z
    Message:               The Gateway has been scheduled by Envoy Gateway
    Observed Generation:   1
    Reason:                Accepted
    Status:                True
    Type:                  Accepted
    Last Transition Time:  2024-06-14T15:03:07Z
    Message:               Deployment replicas unavailable
    Observed Generation:   1
    Reason:                NoResources
    Status:                False
    Type:                  Programmed

the gateway status is this

NAME            CLASS           ADDRESS         PROGRAMMED   AGE
acme-envoy   acme-envoy   IPADDRESS   False        4m19s

[arkodg]

@davem-git can you raise a separate GH issue to highlight the issue you are facing