Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update api doc #3416

Merged
merged 6 commits into from
May 23, 2024
Merged

doc: update api doc #3416

merged 6 commits into from
May 23, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented May 17, 2024

fix: #3414

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner May 17, 2024 06:38
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Comment on lines +34 to +36
- name: JSON
package: k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1
link: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/#json-v1-apiextensions-k8s-io
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Shall we wait this PR to be merged?

@zirain
Copy link
Contributor Author

zirain commented May 23, 2024

LGTM! Shall we wait this PR to be merged?

we can do that with a following PR.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (99f9132) to head (9a107be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
+ Coverage   67.23%   67.25%   +0.02%     
==========================================
  Files         166      166              
  Lines       19439    19439              
==========================================
+ Hits        13070    13074       +4     
+ Misses       5424     5421       -3     
+ Partials      945      944       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 0958433 into envoyproxy:main May 23, 2024
26 checks passed
@zirain zirain deleted the update-api-doc branch May 23, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Reference doc cannot describe types from gateway-api package
3 participants