API for authorization #3138
Closed
API for authorization #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zetaab
reviewed
Apr 9, 2024
| Name string `json:"name"` | ||
|
|
||
| // Value is the value of the claim. | ||
| Value string `json:"value"` |
There was a problem hiding this comment.
Just thinking like groups parameter. Use case could be "i want allow group x only" or "i want allow/deny groups x y z".
|
thanks for picking this up @zhaohuabing , Id suggest by first taking #2652 forward, and then adding more attributes like |
Sure, I didn't notice that one. Close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arkodg @zetaab @rooque @guydc
Related issue: #2250