Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Suppress envoy headers #2364

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

liorokman
Copy link
Contributor

What this PR does / why we need it:

This PR implements #2358

Which issue(s) this PR fixes:
Implements #2358

…uter.

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Lior Okman <lior.okman@sap.com>
@liorokman liorokman requested a review from a team as a code owner December 26, 2023 07:20
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bda0055) 64.73% compared to head (2e4c8a5) 64.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
+ Coverage   64.73%   64.78%   +0.04%     
==========================================
  Files         113      113              
  Lines       16567    16575       +8     
==========================================
+ Hits        10725    10738      +13     
+ Misses       5168     5164       -4     
+ Partials      674      673       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lior Okman <lior.okman@sap.com>
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Lior Okman <lior.okman@sap.com>
@zirain zirain merged commit 1a77c4f into envoyproxy:main Dec 27, 2023
15 checks passed
@arkodg
Copy link
Contributor

arkodg commented Jan 3, 2024

we may need to revisit where this field lives in the future and consider moving it into BackendTrafficPolicy if

  • this feature is something that is tied to the developer persona instead of the system admin persona
  • if there are valid use cases where a user would like to enable this feature at the Gateway level (all HTTPRoutes ) by default but disable it for some explicit routes (using a explicit BackendTrafficPolicy targeted at the route level)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants