feat(translator): Implement BTP CircuitBreaker API #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 64.72% 64.71% -0.01%
==========================================
Files 113 113
Lines 16445 16557 +112
==========================================
+ Hits 10644 10715 +71
- Misses 5130 5168 +38
- Partials 671 674 +3 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Dec 20, 2023
| } | ||
|
|
||
| func setCircuitBreakerPolicyErrorCondition(policy *egv1a1.BackendTrafficPolicy) { | ||
| message := "Unable to translate Circuit Breaker" |
There was a problem hiding this comment.
can we pass an extra errMsg to the func to add some more error msg details such as invalid maxPendingRequests value etc
|
the PR is looking really good, thanks for adding an e2e as well ! |
shawnh2
approved these changes
Dec 21, 2023
| } | ||
|
|
||
| if pcb.MaxParallelRequests != nil { | ||
| if ui32, ok := int64ToUint32(*pcb.MaxParallelRequests); ok { |
There was a problem hiding this comment.
can we add some test here? make sure int64ToUint32 works as expected
Xunzhuo
previously approved these changes
Dec 21, 2023
cnvergence
approved these changes
Dec 21, 2023
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature, implementation of API defined in #2284
What this PR does / why we need it:
Add support for configuring Envoy's circuit breaking settings.
Which issue(s) this PR fixes:
Fixes #2125