Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement setting common TLS parameters in ClientTrafficPolicy #2297

Merged
merged 16 commits into from
Jan 9, 2024

* Require that ALPN constants are also valid ALPN identification

3ca7a9a
Select commit
Loading
Failed to load commit list.
Merged

feat: Implement setting common TLS parameters in ClientTrafficPolicy #2297

* Require that ALPN constants are also valid ALPN identification
3ca7a9a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2024 in 0s

64.63% (target 60.00%)

View this Pull Request on Codecov

64.63% (target 60.00%)

Details

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (3812cb5) 64.66% compared to head (3ca7a9a) 64.63%.
Report is 5 commits behind head on main.

Files Patch % Lines
internal/ir/zz_generated.deepcopy.go 5.08% 52 Missing and 4 partials ⚠️
internal/ir/xds.go 79.16% 4 Missing and 1 partial ⚠️
internal/xds/translator/listener.go 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
- Coverage   64.66%   64.63%   -0.04%     
==========================================
  Files         115      115              
  Lines       16844    17326     +482     
==========================================
+ Hits        10893    11199     +306     
- Misses       5256     5415     +159     
- Partials      695      712      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.