Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: small patch cert-manager doc better experience #2197

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

tanujd11
Copy link
Member

@tanujd11 tanujd11 commented Nov 16, 2023

Annotation for cluster-issuer was also changed it seems:

Checkout https://cert-manager.io/docs/usage/gateway/#supported-annotations

Signed-off-by: Tanuj Dwivedi <dwiveditanuj41@gmail.com>
@tanujd11 tanujd11 requested a review from a team as a code owner November 16, 2023 10:50
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99b1642) 64.17% compared to head (50c3893) 64.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   64.17%   64.20%   +0.02%     
==========================================
  Files         107      107              
  Lines       14924    14924              
==========================================
+ Hits         9578     9582       +4     
+ Misses       4770     4767       -3     
+ Partials      576      575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tanuj Dwivedi <dwiveditanuj41@gmail.com>
@tanujd11
Copy link
Member Author

/retest

@tanujd11 tanujd11 changed the title small patch cert-manager doc better experience doc: small patch cert-manager doc better experience Nov 16, 2023
zirain
zirain previously approved these changes Nov 16, 2023
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
@arkodg
Copy link
Contributor

arkodg commented Nov 16, 2023

looks like we lost https://github.com/envoyproxy/gateway/pull/1945/files during the migration to Hugo

@arkodg arkodg merged commit 94fe41c into envoyproxy:main Nov 16, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants