Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status eq check for ClientTrafficPolicy #1948

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 10, 2023

Relates to #1846

Relates to envoyproxy#1846

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner October 10, 2023 19:02
@arkodg arkodg marked this pull request as draft October 10, 2023 19:09
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1948 (97ff93b) into main (4efe611) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   65.46%   65.37%   -0.09%     
==========================================
  Files          90       90              
  Lines       13362    13367       +5     
==========================================
- Hits         8747     8739       -8     
- Misses       4078     4089      +11     
- Partials      537      539       +2     
Files Coverage Δ
internal/status/status.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@arkodg arkodg marked this pull request as ready for review October 10, 2023 20:32
@arkodg arkodg requested review from a team, LanceEa, chauhanshubham and Xunzhuo and removed request for a team October 11, 2023 01:00
@arkodg arkodg merged commit 3cdeabb into envoyproxy:main Oct 11, 2023
27 of 29 checks passed
@arkodg arkodg deleted the status-eq-ctp branch October 11, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants