feat(crypto): control plane TLS support for Rate Limit Service phase I #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 61.44% 61.61% +0.16%
==========================================
Files 81 81
Lines 12012 12104 +92
==========================================
+ Hits 7381 7458 +77
- Misses 4163 4177 +14
- Partials 468 469 +1
|
arkodg
reviewed
Jun 6, 2023
oowl
force-pushed
the
feat/rate-limit-tls
branch
2 times, most recently
from
2289f4c
to
22ecae5
Compare
oowl
force-pushed
the
feat/rate-limit-tls
branch
3 times, most recently
from
1a7e62e
to
715cce7
Compare
oowl
changed the title
arkodg
reviewed
Jun 13, 2023
internal/infrastructure/kubernetes/ratelimit/resource_provider_test.go
Outdated
Show resolved
Hide resolved
arkodg
reviewed
Jun 13, 2023
|
looks really good @oowl, added one comment, thanks for working on this feature ! |
oowl
force-pushed
the
feat/rate-limit-tls
branch
from
715cce7
to
92c7107
Compare
oowl
force-pushed
the
feat/rate-limit-tls
branch
2 times, most recently
from
1fb2940
to
806588c
Compare
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
Signed-off-by: owl <ouyangjun1999@gmail.com>
oowl
force-pushed
the
feat/rate-limit-tls
branch
from
806588c
to
db4d1c4
Compare
7 tasks
zirain
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
add TLS Support between the envoy and ratelimted services
What this PR does / why we need it:
Which issue(s) this PR fixes:
Relates to #1454