-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: missing NodePort service type description comment #1401
Conversation
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
cc: @zirain wrt #1392 (comment) |
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
- Coverage 62.44% 62.36% -0.09%
==========================================
Files 79 79
Lines 11084 11084
==========================================
- Hits 6921 6912 -9
- Misses 3707 3714 +7
- Partials 456 458 +2 |
it's ok now, leave it for someone who is new to this project? |
What this PR does / why we need it:
Adds missing comment for NodePort type service