Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.4.0: Cherry Pick Fixes #1350

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Release - 0.4.0: Cherry Pick Fixes #1350

merged 2 commits into from
Apr 24, 2023

Commits on Apr 24, 2023

  1. Extension: fix pointer error (#1323) 

    (cherry picked from commit 2bf9607)
Signed-off-by: AliceProxy <alicewasko@datawire.io>
    Alice Wasko committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1cc3cab View commit details
    Browse the repository at this point in the history

  2. fix: add the namespace resource within helm templates (#1332) 

    Add the namespace resource within helm templates

This is unfortunate workaround due the difference in
UX between `helm template` and `helm install`
The project recommends `helm install` as a way to install
EG which supports a `--create-namespace` flag to create a namespace
However we also generate a static YAML using `helm template` as part of
the release artficat so a user can install the YAML directly using
`kubectl` instead of `helm` . The issue here is `helm template` does
not support `--create-namespace`, so instead this commit adds a knob
called `createNamespace` to the Helm chart which is `false` by default,
but turned on during `make generate-manifests`

Fixes: #1307

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 9d6d699)
Signed-off-by: AliceProxy <alicewasko@datawire.io>
    @arkodg
    arkodg authored and AliceProxy committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1fafcc3 View commit details
    Browse the repository at this point in the history