-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: followup kubernetes/infrastruture refactoring. #1337
Conversation
Signed-off-by: qicz <qiczzhu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
- Coverage 62.30% 62.19% -0.12%
==========================================
Files 76 78 +2
Lines 10837 10895 +58
==========================================
+ Hits 6752 6776 +24
- Misses 3640 3665 +25
- Partials 445 454 +9
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: qicz <qiczzhu@gmail.com>
Signed-off-by: qicz <qiczzhu@gmail.com>
Signed-off-by: qicz <qiczzhu@gmail.com>
24bdd67
to
5fca0b3
Compare
@zirain can you take a first look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qicz can you split this into two PRs, one for refactor of applier, and another for the reset part.
2d1925e
to
fa59a65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1330
cc @zirain @arkodg