Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pull request template & update contributing docs. #1314

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

qicz
Copy link
Member

@qicz qicz commented Apr 17, 2023

Fixes: #1315

@qicz qicz requested a review from a team as a code owner April 17, 2023 03:25
@qicz qicz added the documentation Improvements or additions to documentation label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1314 (5a7598c) into main (6baaaf1) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   61.88%   61.85%   -0.03%     
==========================================
  Files          85       85              
  Lines       10852    10852              
==========================================
- Hits         6716     6713       -3     
- Misses       3692     3694       +2     
- Partials      444      445       +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/latest/dev/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@qicz qicz force-pushed the dev-docs branch 2 times, most recently from 5869d5c to 88dd167 Compare April 17, 2023 05:47
@qicz qicz requested a review from Xunzhuo April 17, 2023 05:48
@qicz qicz force-pushed the dev-docs branch 3 times, most recently from 128c998 to 765ef28 Compare April 17, 2023 06:25
Signed-off-by: qicz <qiczzhu@gmail.com>
@zirain
Copy link
Contributor

zirain commented Apr 17, 2023

EG use squash merge, do not push -f every time for better review.

@qicz
Copy link
Member Author

qicz commented Apr 17, 2023

EG use squash merge, do not push -f every time for better review.

I know squash will merge all commits into one commit. sometimes -f to fix codecov timeout or clarify the commit message.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should make release note generation easier in the future

@zirain zirain merged commit f8da5b4 into envoyproxy:main Apr 18, 2023
@qicz qicz deleted the dev-docs branch April 20, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support PR template
4 participants