Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce code coverage thresholds #74

Closed
skriss opened this issue May 25, 2022 · 16 comments
Closed

enforce code coverage thresholds #74

skriss opened this issue May 25, 2022 · 16 comments
Labels
area/ci CI and build related issues good first issue Good for newcomers help wanted Extra attention is needed priority/low Label used to express the "low" priority level
Milestone
0.4.0-rc.1

Comments

@skriss
Copy link
Contributor

skriss commented May 25, 2022

The project should have code coverage reporting and enforce certain levels of code coverage for PRs. https://about.codecov.io/ is a good option that integrates well with GitHub and is free for open-source projects.
@skriss skriss added this to the 0.2.0 milestone May 25, 2022
@danehans danehans added area/ci CI and build related issues good first issue Good for newcomers help wanted Extra attention is needed labels May 25, 2022
@ethanhanjiahao
Copy link
Contributor

/accept

I want try to resolve this issue

@danehans
Copy link
Contributor

@ethanhanjiahao thanks for your willingness to help. Please assign yourself the issue if you're going to work on it.

@ethanhanjiahao
Copy link
Contributor

@ethanhanjiahao thanks for your willingness to help. Please assign yourself the issue if you're going to work on it.

yeah, but i cannot assign to me. Can you assign the issue to me. I will work on it

@ethanhanjiahao ethanhanjiahao mentioned this issue May 30, 2022
Merged
@youngnick youngnick mentioned this issue May 30, 2022
Closed
skriss pushed a commit that referenced this issue Jun 3, 2022
@ethanhanjiahao
add code coverage reporting for PR & push builds (#80)
bc2c27f 
Adds code coverage reporting via Codecov
for PR and push builds.

Updates #74.

Signed-off-by: ethanhanjiahao <xidianhanjiahao@gmail.com>
@skriss
Copy link
Contributor Author

skriss commented Jun 3, 2022

Still to do: add PR checks that enforce required code coverage #'s.

@danehans
Copy link
Contributor

danehans commented Aug 2, 2022

Moving this to backlog since codecov was added but coverage #s are not required.

@danehans danehans modified the milestones: 0.2.0-rc1, Backlog Aug 2, 2022
@arkodg
Copy link
Contributor

arkodg commented Sep 24, 2022

we are currently at ~60% code coverage and this is a decent threshold to start off with imho.
based on codecov/codecov-action#554 I'm unsure if threshold is supported by the GHA or not.
Hey @ethanhanjiahao is this something you could further look into and enhance in our CI ?

@ethanhanjiahao
Copy link
Contributor

we are currently at ~60% code coverage and this is a decent threshold to start off with imho. based on codecov/codecov-action#554 I'm unsure if threshold is supported by the GHA or not. Hey @ethanhanjiahao is this something you could further look into and enhance in our CI ?

yes， i can enhance it

@arkodg arkodg modified the milestones: Backlog, 0.2.0 Sep 26, 2022
@danehans
Copy link
Contributor

danehans commented Oct 3, 2022

@ethanhanjiahao can you please confirm if you can fix this issue by the v0.2.0 milestone?

@ethanhanjiahao ethanhanjiahao mentioned this issue Oct 6, 2022
Merged
@arkodg
Copy link
Contributor

arkodg commented Oct 10, 2022

fixed with #513

@arkodg arkodg closed this as completed Oct 10, 2022
@arkodg
Copy link
Contributor

arkodg commented Dec 9, 2022

reopening this issue since a drop a coverage didn't manage to fail the CI check (seen #728 (comment))

@arkodg arkodg reopened this Dec 9, 2022
@arkodg arkodg modified the milestones: 0.2.0, 0.3.0-rc.1 Dec 9, 2022
@ethanhanjiahao
Copy link
Contributor

reopening this issue since a drop a coverage didn't manage to fail the CI check (seen #728 (comment))

oddly, fork main to my own repo, it is ok. I make a test ethanhanjiahao#2, coverage is down to 36.88%, CI failed.

@danehans danehans modified the milestones: 0.3.0-rc.1, 0.3.0 Jan 12, 2023
@danehans
Copy link
Contributor

danehans commented Feb 8, 2023

Moving to v0.4 since no one is assigned to this issue and it's not a release blocker.

@danehans danehans modified the milestones: 0.3.0, 0.4.0-rc.1 Feb 8, 2023
@danehans danehans added the priority/low Label used to express the "low" priority level label Feb 8, 2023
@arkodg arkodg changed the title add code coverage checks enforce code coverage thresholds Feb 8, 2023
@arkodg
Copy link
Contributor

arkodg commented Mar 9, 2023 •
edited
Loading

codecov maintainers suggested that we run the Codecov Github App
codecov/codecov-action#554 (comment)
@lizan can you help install this ?

@arkodg
Copy link
Contributor

arkodg commented Mar 27, 2023

codecov maintainers suggested that we run the Codecov Github App
codecov/codecov-action#554 (comment)
@lizan can you help install this ?

@mattklein123 @phlax can you help install the CodeCov Github App for this repository so we can ensure code coverage thresholds kick in, TIA !

@mattklein123
Copy link
Member

Should be installed now.

arkodg added a commit to arkodg/gateway that referenced this issue Mar 28, 2023
@arkodg
[DO NOT MERGE} Check codecov thresholds
de26cf4 
Relates to envoyproxy#74

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Mar 28, 2023
Closed
@arkodg
Copy link
Contributor

arkodg commented Mar 28, 2023 •
edited
Loading

thanks @mattklein123 can confirm via #1234
that the threshold is being highlighted in the CI, and CI fails if the target or thresholds is not met
Screenshot 2023-03-28 at 10 14 20 AM

@arkodg arkodg closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI and build related issues good first issue Good for newcomers help wanted Extra attention is needed priority/low Label used to express the "low" priority level
Projects
None yet
Milestone
0.4.0-rc.1
Development

No branches or pull requests
5 participants
@danehans @skriss @mattklein123 @arkodg @ethanhanjiahao