Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support patching envoy service #2716

Closed
arkodg opened this issue Feb 27, 2024 · 0 comments · Fixed by #2719
Closed

Support patching envoy service #2716

arkodg opened this issue Feb 27, 2024 · 0 comments · Fixed by #2719
Assignees
@arkodg
Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. road-to-ga
Milestone
v1.0.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 27, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

Similar to patching the envoy deployment (implemented in #2374) also support patching envoy service
@arkodg arkodg added triage road-to-ga area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. and removed triage labels Feb 27, 2024
@arkodg arkodg added this to the v1.0.0-rc1 milestone Feb 27, 2024
@arkodg arkodg added the help wanted Extra attention is needed label Feb 27, 2024
@arkodg arkodg self-assigned this Feb 27, 2024
@arkodg arkodg removed the help wanted Extra attention is needed label Feb 28, 2024
arkodg added a commit to arkodg/gateway that referenced this issue Feb 28, 2024
@arkodg
feat: support patch in envoyService
3609a83 
Fixes: envoyproxy#2716

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Feb 28, 2024
Merged
arkodg added a commit to arkodg/gateway that referenced this issue Feb 28, 2024
@arkodg
feat: support patch in envoyService
47c186f 
Fixes: envoyproxy#2716

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Xunzhuo added a commit that referenced this issue Feb 29, 2024
@arkodg @Xunzhuo @zirain
feat: support patch in envoyService (#2719)
fa6b0d4 
* feat: support patch in envoyService

Fixes: #2716

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix error handling

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
Co-authored-by: zirain <zirain2009@gmail.com>
@arkodg arkodg mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkodg arkodg

Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. road-to-ga
Projects
Envoy Gateway: The Road to GA
Status: Done
Milestone
v1.0.0-rc1
Development

Successfully merging a pull request may close this issue.

feat: support patch in envoyService arkodg/gateway
1 participant
@arkodg