Skip to content

Commit

Permalink
add comment
Browse files Browse the repository at this point in the history
Signed-off-by: zirain <zirain2009@gmail.com>
  • Loading branch information
zirain committed Oct 29, 2023
1 parent 4fe491b commit 52eccb0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/e2e/tests/controlplane.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ var ControlPlaneTest = suite.ConformanceTest{
t.Errorf("failed to get service %s : %v", nn.String(), err)
}

// too much flakes in the test if timeout is 1 minute
// this should not take so long, but we give it a long timeout to be safe, and poll every second
if err := wait.PollUntilContextTimeout(context.TODO(), time.Second, 2*time.Minute, true,
func(_ context.Context) (done bool, err error) {
if err := ScrapeMetrics(t, suite.Client, nn, 19001, "/metrics"); err != nil {
Expand Down

0 comments on commit 52eccb0

Please sign in to comment.