Remove duplicate REGISTER_FACTORY causing build failure#1047
Closed
Copilot wants to merge 6 commits intocopilot/enhance-http-filter-cc-examplefrom
Closed
Remove duplicate REGISTER_FACTORY causing build failure#1047Copilot wants to merge 6 commits intocopilot/enhance-http-filter-cc-examplefrom
Copilot wants to merge 6 commits intocopilot/enhance-http-filter-cc-examplefrom
Conversation
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add upstream filter factory registration for HTTP filter example
Add upstream filter support to http-filter-cc example
Feb 3, 2026
Copilot
AI
changed the title
Add upstream filter support to http-filter-cc example
Fix createRouteSpecificFilterConfigTyped return type for Envoy API change
Feb 4, 2026
…tusOr Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
Fix createRouteSpecificFilterConfigTyped return type for Envoy API change
Remove duplicate REGISTER_FACTORY causing build failure
Feb 4, 2026
Copilot stopped work on behalf of
phlax due to an error
February 4, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build error: redefinition of
forceRegisterFilterFactorydue to callingREGISTER_FACTORYtwice with the same factory class.Changes
REGISTER_FACTORY(FilterFactory, Server::Configuration::UpstreamHttpFilterConfigFactory)callDualFactoryBaseautomatically registers the factory for both downstream and upstream contextsDualFactoryBaseinherits from bothNamedHttpFilterConfigFactoryandUpstreamHttpFilterConfigFactory, so a single registration withNamedHttpFilterConfigFactoryis sufficient: