Skip to content

[WIP] Add CI testing for http-filter-cc example#1042

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/add-ci-testing-http-filter-cc
Closed

[WIP] Add CI testing for http-filter-cc example#1042
Copilot wants to merge 1 commit intomainfrom
copilot/add-ci-testing-http-filter-cc

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Add CI testing for the new http-filter-cc example, similar to how wasm-cc is tested.

Changes needed

1. Create .github/workflows/_verify_http_filter.yml

Create a new reusable workflow that runs the verify script for http-filter-cc:

name: Verify/HTTP Filter

permissions:
  contents: read

on:
  workflow_call:


jobs:
  http-filter-cc:
    runs-on: ubuntu-24.04
    steps:
    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
    - run: |
        docker pull envoyproxy/envoy:dev
        DEV_CONTAINER_ID=$(docker inspect --format='{{.Id}}' envoyproxy/envoy:dev)
        echo "DEV_CONTAINER_ID=${DEV_CONTAINER_ID}" >> $GITHUB_ENV
    - run: |
        ./verify.sh
      working-directory: http-filter-cc

2. Update .github/workflows/verify.yml

Add a call to the new workflow:

name: Verify

permissions:
  contents: read

on:
  pull_request:
  push:
    branches:
    - main

concurrency:
  group: >-
    ${{ github.event.inputs.head_ref || github.run_id }}


jobs:
  examples:
    uses: ./.github/workflows/_verify_examples.yml
  wasm:
    uses: ./.github/workflows/_verify_wasm.yml
  http-filter:
    uses: ./.github/workflows/_verify_http_filter.yml

Context

  • The http-filter-cc example has its own MODULE.bazel and sits outside the main repo's bazel setup (similar to wasm-cc)
  • It already has a verify.sh script that tests the docker compose setup
  • This follows the same pattern as _verify_wasm.yml which tests the wasm-cc example

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI requested a review from phlax February 3, 2026 15:52
Copilot stopped work on behalf of phlax due to an error February 3, 2026 15:52
@phlax phlax closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants