Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for outputting missing tests #8240

Merged
merged 8 commits into from
Sep 17, 2019
Merged

Add support for outputting missing tests #8240

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed87a19
Add support for outputting missing tests
Sep 13, 2019
93d6abe
Merge remote-tracking branch 'upstream/master' into missing-test-output
Sep 13, 2019
031997b
Dump proto and make name assignment method private
Sep 13, 2019
3bb67b0
Formatting
Sep 13, 2019
c56a03b
Kick CI
Sep 13, 2019
7c36de4
Use UUID instead of int as route name
Sep 16, 2019
3c17813
Move UUID generation inside for loop
Sep 16, 2019
e6cc09b
Small fixes
Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move UUID generation inside for loop 
Signed-off-by: Lisa Lu <lisalu@lyft.com>
  • Loading branch information
Lisa Lu committed Sep 16, 2019
commit 3c17813b8d4528633d67c3931c59ea1097ad78b9
4 changes: 2 additions & 2 deletions test/tools/router_check/router.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ RouterCheckTool RouterCheckTool::create(const std::string& router_config_file,
// check.
void RouterCheckTool::assignUniqueRouteNames(envoy::api::v2::RouteConfiguration& route_config) {
Runtime::RandomGeneratorImpl random;
std::string route_name = random.uuid();
std::string route_name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove variable, just inline uuid() call on line 97

for (auto& host : *route_config.mutable_virtual_hosts()) {
for (auto& route : *host.mutable_routes()) {
route.set_name(route_name);
route_name = random.uuid();
route.set_name(route_name);
}
}
}
Expand Down