Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_cc_library: add export of foo_with_external_headers #8005

Merged
merged 8 commits into from
Aug 22, 2019
Merged

envoy_cc_library: add export of foo_with_external_headers #8005

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4abf358
Flag for specifying handled include prefixes
oschaaf Aug 21, 2019
16c5ea7
Add export of foo_with_external_headers
oschaaf Aug 21, 2019
e0a8622
Merge remote-tracking branch 'upstream/master' into include-prefixes
oschaaf Aug 21, 2019
4c04cdf
Merge branch 'include-prefixes' of github.com:oschaaf/envoy into incl…
oschaaf Aug 22, 2019
a3d97f8
Add comment
oschaaf Aug 22, 2019
97fdd52
Undo accidental change
oschaaf Aug 22, 2019
e92ae7a
Add back whitespace add EOF
oschaaf Aug 22, 2019
0190f71
Fix format
oschaaf Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bazel/envoy_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,17 @@ def envoy_cc_library(
strip_include_prefix = strip_include_prefix,
)

# Intended for usage by external consumers. This allows them to disambiguate
# include paths via `external/envoy...`
native.cc_library(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining what this is for and how it should be used (i.e. only by external projects)? Otherwise LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

name = name + "_with_external_headers",
hdrs = hdrs,
copts = envoy_copts(repository) + copts,
visibility = visibility,
deps = [":" + name],
strip_include_prefix = strip_include_prefix,
)

# Used to specify a library that only builds on POSIX
def envoy_cc_posix_library(name, srcs = [], hdrs = [], **kargs):
envoy_cc_library(
Expand Down