Replace system time with monotonic time for calculating intervals#748
Merged
mattklein123 merged 8 commits intomasterfrom Apr 17, 2017
Merged
Replace system time with monotonic time for calculating intervals#748mattklein123 merged 8 commits intomasterfrom
mattklein123 merged 8 commits intomasterfrom
Conversation
danielhochman
changed the title
Contributor
|
lgtm |
Member
|
@dnoe do you mind giving this a first pass? |
include/envoy/common/time.h
Outdated
| * Less typing for common system time type. | ||
| * Less typing for common system time and steady time type. | ||
| * | ||
| * SystemTime should be used when getting a time to present to the user, e.g. for logging |
Member
There was a problem hiding this comment.
super nit: '.' at the end here and there.
test/server/guarddog_impl_test.cc
Outdated
| // At 300ms we shouldn't have hit the timeout yet: | ||
| mock_time_ += 300; | ||
| // EXPECT_CALL(time_source_, currentSystemTime()).WillRepeatedly(testing::Return(time_point_)); | ||
| // EXPECT_CALL(time_source_, currentTime()).WillRepeatedly(testing::Return(time_point_)); |
Member
There was a problem hiding this comment.
if there is an expectation on this call, we could do EXPECT_CALL(time_source_, currentTime()) since we have default behavior set in ctor.
Contributor
Author
There was a problem hiding this comment.
out of scope. i believe @dnoe was working on cleaning up these tests separately anyways.
Member
There was a problem hiding this comment.
Can you just delete these commented out statements here and below as long as you are in here. They can be added back later if needed.
Merged
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM just small deletion in test code needed.
mattklein123
approved these changes
Apr 17, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #312
TODO need to look at: