-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: similar build flags to cmake for corresponding build types (#4… #720
Merged
Commits on Apr 7, 2017
-
bazel: similar build flags to cmake for corresponding build types (en…
…voyproxy#415). Bazel has 3 compilation modes out-of-the-box {fastbuild, opt, dbg}, see https://bazel.build/versions/master/docs/bazel-user-manual.html#flag--compilation_mode. The cmake build flags for normal/debug/server_only/asan/coverage are at envoyproxy#415 (comment). Below are the relevant flags (ignoring -include etc.) from the various builds. Lines that begin with * are those that include additional flags we're injecting. fastbuild: -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -frandom-seed=... -fPIC *-DBAZEL_BRINGUP -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual *-Wold-style-cast '-std=c++0x' -includeprecompiled/precompiled.h -DDEBUG -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' dbg: -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g '-std=c++0x' -frandom-seed=... -fPIC *-DBAZEL_BRINGUP -Wall -Wextra -Werror -Wnon-virtual-dtor *-Woverloaded-virtual -Wold-style-cast '-std=c++0x' -includeprecompiled/precompiled.h -ggdb3 -DDEBUG -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' opt: -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++0x' -frandom-seed=... *-DBAZEL_BRINGUP -Wall -Wextra -Werror -Wnon-virtual-dtor *-Woverloaded-virtual -Wold-style-cast '-std=c++0x' -includeprecompiled/precompiled.h -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' This PR requires envoyproxy#716 to merge, since envoyproxy#716 provides some important changes to how the headers are exported from the 3rd party deps to allow -Wextra and -Wold-style-cast to work. I've verified that we now have a 100% static envoy-static build, which ldd tells me is not a dynamic binary. % bazel build -c opt //source/exe:envoy-static.stripped Target //source/exe:envoy-static.stripped up-to-date: bazel-bin/source/exe/envoy-static.stripped % ldd bazel-bin/source/exe/envoy-static.stripped not a dynamic executable % ls -lh bazel-bin/source/exe/envoy-static.stripped -r-xr-xr-x 1 htuch eng 8.1M Apr 7 15:46 bazel-bin/source/exe/envoy-static.stripped
Configuration menu - View commit details
-
Copy full SHA for 7cebb0e - Browse repository at this point
Copy the full SHA 7cebb0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2423d5f - Browse repository at this point
Copy the full SHA 2423d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a3b1c - Browse repository at this point
Copy the full SHA 63a3b1cView commit details
Commits on Apr 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b55e524 - Browse repository at this point
Copy the full SHA b55e524View commit details -
Configuration menu - View commit details
-
Copy full SHA for f47df63 - Browse repository at this point
Copy the full SHA f47df63View commit details
Commits on Apr 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1a75897 - Browse repository at this point
Copy the full SHA 1a75897View commit details
Commits on Apr 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4969692 - Browse repository at this point
Copy the full SHA 4969692View commit details -
Configuration menu - View commit details
-
Copy full SHA for b28d32e - Browse repository at this point
Copy the full SHA b28d32eView commit details -
s/strip_include_prefix/includes/g in ci/prebuilt/BUILD to avoid -Wext…
…ra etc. applying to external dep headers.
Configuration menu - View commit details
-
Copy full SHA for 619dd3c - Browse repository at this point
Copy the full SHA 619dd3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4baffe - Browse repository at this point
Copy the full SHA e4baffeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.