Update Bazel dependencies on GRPC and protoc_gen_validate #7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @keith |
|
Rather than add When will a new version of PGV be cut with the commit |
They include fixes for future Bazel changes. In particular, the repository can now build with `--incompatible_depset_is_not_iterable`, which will be included in Bazel 0.27. Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>
…date Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>
It looks like more recent commits in PGV cause a failure. Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>
keith
approved these changes
May 30, 2019
|
I asked about a new release on that repo but it's blocked on bufbuild/protoc-gen-validate#191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They include fixes for future Bazel changes. In particular, the
repository can now build with
--incompatible_depset_is_not_iterable,which will be included in Bazel 0.27.
Description:
Risk Level: low
Testing:
bazel build --nobuild ... --incompatible_depset_is_not_iterable#6995