Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add extension policy #6678

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Conversation

dschaller
Copy link
Member

Signed-off-by: Derek Schaller dschaller@lyft.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: Formalize the extension policy outlined in this Google doc.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Derek Schaller <dschaller@lyft.com>
EXTENSION_POLICY.md Outdated Show resolved Hide resolved
@junr03
Copy link
Member

junr03 commented Apr 23, 2019

@dschaller I will let @lizan do the review for content. But I have one thought: should the content live under source/extensions?

Derek Schaller and others added 2 commits April 23, 2019 13:57
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Signed-off-by: Derek <dschaller@users.noreply.github.com>
@dschaller
Copy link
Member Author

Force-pushed for the DCO check. Same content.

@dschaller
Copy link
Member Author

@junr03 I did think about that but for consistency I decided to put it at the root. It seems like all the governing files live there. Happy to move it around though.

Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lizan lizan merged commit 3573b07 into envoyproxy:master Apr 24, 2019
@dschaller dschaller deleted the extension-policy branch April 24, 2019 06:10
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 24, 2019
* master:
  docs: add extension policy (envoyproxy#6678)
  ext_authz: added ability to detect partial request body data (envoyproxy#6583)
  version_history.rst: jwt_authn change missed 1.10.0 (envoyproxy#6684)
  docs: fix link in pull request template (envoyproxy#6679)
  Explicitly convert absl::string_view to std::string. (envoyproxy#6687)
  docs: improving watermark docs/comments (envoyproxy#6683)
  http filter: add CSRF filter (envoyproxy#6470)
  event: reintroduce dispatcher stats (envoyproxy#6659)
  security: postmortem for CVE-2019-990[01] (envoyproxy#6597)
  Improve build rules for (test only) library quic_port_utils. (envoyproxy#6672)
  spell check: skip unsupported extensions when called with a file (envoyproxy#6648)
  Changed TestHooks to ListenerHooks (envoyproxy#6642)
  proto: move extension-specific linking validation into extensions (envoyproxy#6657)
  stats: add/test heterogenous set of StatNameStorage objects. (envoyproxy#6504)
  docs: move xds protocol to rst (envoyproxy#6670)
  fix version history order (envoyproxy#6671)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants