Skip to content

Fix format issue: s/absl::nullopt/std::nullopt#45907

Merged
tyxia merged 1 commit into
envoyproxy:mainfrom
penguingao:fix_format
Jul 1, 2026
Merged

Fix format issue: s/absl::nullopt/std::nullopt#45907
tyxia merged 1 commit into
envoyproxy:mainfrom
penguingao:fix_format

Conversation

@penguingao

Copy link
Copy Markdown
Contributor

Commit Message: Fix format issue in test/extensions/access_loggers/common/grpc_access_logger_test.cc. it uses absl::nullopt which breaks CI
Additional Description:
Risk Level: low
Testing: ran code format
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Peng Gao <pengg@google.com>

@tyxia tyxia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Seems to be a very simple fix and this kind of change has been merged in #45607

@tyxia tyxia enabled auto-merge (squash) July 1, 2026 00:08
@tyxia tyxia merged commit 437c4df into envoyproxy:main Jul 1, 2026
28 checks passed
@penguingao penguingao deleted the fix_format branch July 1, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants