Fix compile_time_options CI failure: apply CommandParser::parse StatusOr change on top of CVE-2026-47220 fix#45819
Closed
yanavlasov with Copilot wants to merge 6 commits into
Closed
Fix compile_time_options CI failure: apply CommandParser::parse StatusOr change on top of CVE-2026-47220 fix#45819yanavlasov with Copilot wants to merge 6 commits into
yanavlasov with Copilot wants to merge 6 commits into
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: yavlasov <yavlasov@google.com>
Signed-off-by: yavlasov <yavlasov@google.com>
- Change CommandParser::parse to return absl::StatusOr<FormatterProviderPtr> - Update all formatter implementations and extensions - Update all callers and tests to use new StatusOr return type - Preserve CVE-2026-47220 fix (null checks in getHostFromHeaders) - Keep CVE tests for empty headers in substitution_formatter_test.cc Co-authored-by: yanavlasov <6360027+yanavlasov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for compile time options
Fix compile_time_options CI failure: apply CommandParser::parse StatusOr change on top of CVE-2026-47220 fix
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #45752 ("Change CommandParser::parse to return StatusOr") was based on
mainbefore the CVE-2026-47220 fix (commit4a70d8d594) landed. The CVE fix added null guards toRequestedServerNameFormatter::getHostFromHeaders()forHost()andEnvoyOriginalHost()headers. The PR's code removed those guards, causing runtime crashes incompile_time_optionsCI (which enables UHV and exercises more header edge cases).Changes
envoy/formatter/substitution_formatter.h):CommandParser::parsevirtual method now returnsabsl::StatusOr<FormatterProviderPtr>instead ofFormatterProviderPtrsource/common/formatter/,source/extensions/formatter/): Allparseoverrides updated to returnabsl::StatusOr<FormatterProviderPtr>cel,dynamic_modules,file_content,generic_secret,metadata,req_without_query,xfcc_value, DNS filter access log — all updatedgetHostFromHeaders()retains null checks from the CVE-2026-47220 fix:stream_info_no_requested_name_no_headers) preserved alongside updated StatusOr call sites