Skip to content

Conversation

@phlax
Copy link
Member

@phlax phlax commented Nov 23, 2025

this does some groundwork for switching to hermetic llvm toolchains

  • move platform registration to bazel/platforms
  • add BAZEL_LLVM_PATH var that can be set via repo_env for setting local llvm install
  • add @mobile_clang_platform

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 23, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #42202 was opened by phlax.

see: more, trace.

@phlax phlax force-pushed the bazel-platforms branch 2 times, most recently from 47ecea5 to 8fd7653 Compare November 23, 2025 10:15
@phlax phlax changed the title bazel/platforms: Setups and cleanups [WIP] bazel/platforms: Setups and cleanups Nov 23, 2025
@phlax phlax marked this pull request as draft November 23, 2025 10:16
@phlax phlax force-pushed the bazel-platforms branch 2 times, most recently from f41b358 to 0f4e1a2 Compare November 23, 2025 10:24
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] bazel/platforms: Setups and cleanups bazel/platforms: Setups and cleanups Nov 23, 2025
@phlax phlax marked this pull request as ready for review November 23, 2025 18:53
@phlax
Copy link
Member Author

phlax commented Nov 23, 2025

cc @jwendell @zirain @abeyad @danzh2010

this adds a repo env var BAZEL_LLVM_PATH - its not used yet - but when its hooked up this will be the way to use a locally installed llvm - ie

bazel build --repo_env=BAZEL_LLVM_PATH=/path/to/llvm --config=clang //some:target

i expect using this to be a rare exception tho - because the default (ie --confg=clang) will just pull in the correct toolchain so the need to install locally should be mostly gone

@phlax phlax enabled auto-merge (squash) November 23, 2025 18:57
@phlax
Copy link
Member Author

phlax commented Nov 23, 2025

/retest

@phlax phlax merged commit c175fac into envoyproxy:main Nov 23, 2025
24 of 25 checks passed
@zirain zirain mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants